Compact Web: Missing --web.route-prefix and --web.external-prefix wrong

[jdfalk]

Thanos, Prometheus and Golang version used:
Using official docker release for 0.12.2

Object Storage Provider:
NA

What happened:
--web.external-prefix= is supposed to be for the external path as referred to in links but is supposed to serve the content still from /
--web.route-prefix= is supposed to actually serve it on a subpath, unfortunately compact currently lacks this flag.

From the documentation of query:

 --web.route-prefix=""      Prefix for API and UI endpoints. This allows thanos UI to be served on a sub-path. This option is analogous to --web.route-prefix of Promethus.
 --web.external-prefix=""   Static prefix for all HTML links and redirect URLs in the UI query web interface. Actual endpoints are still served on / or the web.route-prefix. This allows thanos UI to be served behind a reverse proxy that strips a URL sub-path.

From the documentation of compact (same as query just missing route-prefix):

--web.external-prefix=""  Static prefix for all HTML links and redirect URLs in the bucket web UI interface. Actual endpoints are still served on / or the web.route-prefix. This allows thanos bucket web UI to be served behind a reverse proxy that strips a URL sub-path.

If connecting to localhost it should be http://localhost:10902/loaded but on the reverse proxy it would be http://external/prefix/loaded which would get rewritten as http://internal/loaded

What you expected to happen:
Compact should follow the behavior as defined in the documentation and the other components of thanos.

How to reproduce it (as minimally and precisely as possible):

1. thanos compact --http-address="0.0.0.0:10902" --web.external-prefix=/bucket
2. go to http://localhost:10902/global -- won't work
3. go to http://localhost:10902/bucket/global -- does work but shouldn't because it's the wrong option.

Anything else we need to know:
This was incorrectly fixed in #2338
The code as it was, was correct, what the submitter really wanted was the --web.route-prefix which is missing from thanos compact. He should not expect to see anything outside of / if using --web.external-prefix.

[GiedriusS]

We plan on fixing this soon. cc @prmsrswt

[stale]

Hello 👋 Looks like there was no activity on this issue for last 30 days.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity for next week, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[stale]

Hello 👋 Looks like there was no activity on this issue for last 30 days.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity for next week, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[stale]

Closing for now as promised, let us know if you need this to be reopened! 🤗

[stale]

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[stale]

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[onprem]

Still valid, and help wanted!

[stale]

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[rodrigoscferraz]

Same here...
Set --web.external-prefix=tools/thanos-bucketweb

go to http://domain/tools/thanos-bucket -- won't work
go to http://domain/tools/thanos-bucket/metrics -- does work

Looking into HTTP response, seems like the /static is pointing to tools/static instead of tools/thanos-bucketweb/static...i also tried set --web.external-prefix=tools , /tools and a lot of other combinations, but nothing works

[stale]

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[ataahua]

Still ongoing. set the

--web.route-prefix=/xxxx
--web.external-prefix=/xxxx

and it's still not working, it ignores the flags, using the latest ver available, 0.24.0

[stale]

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[rodrigoscferraz]

Still ongoing

[metonymic-smokey]

If no one else is working on it, maybe I could take a stab at this sometime?
Thanks!

[stale]

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.