Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

receive: Use PathOrContent file for the hashring #3026

Closed
bwplotka opened this issue Aug 12, 2020 · 8 comments · Fixed by #3121
Closed

receive: Use PathOrContent file for the hashring #3026

bwplotka opened this issue Aug 12, 2020 · 8 comments · Fixed by #3121

Comments

@bwplotka
Copy link
Member

This:

hashringsFile := cmd.Flag("receive.hashrings-file", "Path to file that contains the hashring configuration.").

@squat
Copy link
Member

squat commented Aug 12, 2020

Specifically, we should allow the Thanos receive component to also take the hashrings configuration as content passed directly to the flag rather than only as file

@kakkoyun kakkoyun changed the title hashring: Use PathOrContent file. receive: Use PathOrContent file for the hashring Aug 12, 2020
@Sylfrena
Copy link

so you mean that this flag should either take a file path or the file contents directly as string?

@squat
Copy link
Member

squat commented Aug 20, 2020

yes, that's right :)) it should work just like the objstore flags, which use https://github.com/thanos-io/thanos/blob/master/pkg/extflag/pathorcontent.go#L29:6

@daksh-sagar
Copy link
Contributor

@bwplotka Can I work on this, please?

@kakkoyun
Copy link
Member

@daksh-sagar I have actually a PR to fix this #3121. Sorry I've forgotten to update this issue.

@daksh-sagar
Copy link
Contributor

@kakkoyun It's allright 🤓

@stale
Copy link

stale bot commented Nov 16, 2020

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Nov 16, 2020
@kakkoyun
Copy link
Member

#3121 is still open and waiting for review cc @squat

@stale stale bot removed the stale label Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants