Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mixin: Introduce flexible multi-cluster/namespace mode for alerts and dashboards #3867

Closed
kakkoyun opened this issue Mar 3, 2021 · 6 comments

Comments

@kakkoyun
Copy link
Member

kakkoyun commented Mar 3, 2021

This would be useful for users who don't use Kubernetes. In the current state of mixin we assume, there's a namespace label for all metrics. This is a Kubernetes term, it'd be better to be environment agnostic.

cc @metalmatze @brancz

@metalmatze
Copy link
Contributor

Basically we should setup Thanos with systemd once and check that the mixin works as expected.
We could do something similar to the multi cluster mode that we have with the kubernetes-mixin and enable kuberentes in a config.

@brancz
Copy link
Member

brancz commented Mar 4, 2021

Aside from removing kubernetes labels .. is there really anything else we can do other than allowing the user to specify what label(s) make two clusters distinct?

@kakkoyun
Copy link
Member Author

kakkoyun commented Mar 4, 2021

We'll definitely let them specify the labels and maybe we can provide a way to introduce different hierarchies that would both work for alerts and dashboards (e.g region, cluster, namespace etc). Basically, let them specify a layer. From that, we can inject a variable, a dropdown to dashboards and inject selectors/aggregators to alerts.

@brancz
Copy link
Member

brancz commented Mar 4, 2021

Makes sense 👍

@stale
Copy link

stale bot commented Jun 2, 2021

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Jun 2, 2021
@kakkoyun
Copy link
Member Author

kakkoyun commented Jun 3, 2021

Done.

@kakkoyun kakkoyun closed this as completed Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants