Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert relabelling for Thanos Rule #4122

Closed
trutty opened this issue Apr 29, 2021 · 1 comment · Fixed by #4125
Closed

Alert relabelling for Thanos Rule #4122

trutty opened this issue Apr 29, 2021 · 1 comment · Fixed by #4125

Comments

@trutty
Copy link
Contributor

trutty commented Apr 29, 2021

Is your proposal related to a problem?

Prometheus has a powerful alert relabelling feature to dynamically rewrite the label set of an alert before sending it to an Alertmanager. See

Thanos Rule is currently missing this feature, so a migration from Prometheus is not possible without loosing functionality.

The idea to have alert relabelling was proposed some time ago with #660.

Describe the solution you'd like

Thanos Rule could implement the same functionality as Prometheus and supply a command line flag to provide the YAML configuration. As far as I see it, most of the source code is reusable with https://github.com/prometheus/prometheus/tree/main/pkg/relabel.

Describe alternatives you've considered

none

Additional context

I could provide a PR which would implement the feature.

@yeya24
Copy link
Contributor

yeya24 commented Apr 29, 2021

Yeah, it would be good to have this feature. If you have a pr already please go ahead! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants