Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proposal to remove Gossip #484

Closed
bwplotka opened this issue Aug 23, 2018 · 7 comments
Closed

Add proposal to remove Gossip #484

bwplotka opened this issue Aug 23, 2018 · 7 comments

Comments

@bwplotka
Copy link
Member

Additionally fix https://github.com/improbable-eng/thanos/blob/master/docs/getting_started.md#communication-between-components ASAP to stop confusion around which component should talk with which component.

@jdfalk
Copy link
Contributor

jdfalk commented Aug 23, 2018

Is there a planned replacement or will static addresses be the only option?

@bwplotka
Copy link
Member Author

bwplotka commented Aug 23, 2018

All will be covered by proposal (:

TL;DR: File SD is planned as a replacement. (Only on querier and ruler, as those only requires such logic)

@tdabasinskas
Copy link
Contributor

tdabasinskas commented Aug 27, 2018

It would actually be nice to have support for DNS-based SD, so we could provide a single FQDN, e.g. --store stores.thanos.mycompany.org (which can be under Consul, if needed), for the querier, which would resolve and use all the IP resolved under the DNS name. 🙂

@bwplotka
Copy link
Member Author

Done.

@drax68
Copy link

drax68 commented Apr 19, 2019

Doesn't seems to be a well thought decision to remove autodiscovery for tool that supposed to be used in dynamic environments like aws with instances going up and down for whatever reason.

@bwplotka
Copy link
Member Author

bwplotka commented Jun 1, 2019

@drax68 did you have a chance to read the proposal? DNS discovery gives exactly the same dynamicity without massive overhead (and other disadvantage mentioned in document) of gossip protocol (:

Let me know if any other functionality is missing.

@bwplotka
Copy link
Member Author

bwplotka commented Jun 1, 2019

Proposal completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants