Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bucket tool: support other type of matchers in replicate #5038

Closed
yeya24 opened this issue Jan 7, 2022 · 5 comments · Fixed by #6035
Closed

Bucket tool: support other type of matchers in replicate #5038

yeya24 opened this issue Jan 7, 2022 · 5 comments · Fixed by #6035

Comments

@yeya24
Copy link
Contributor

yeya24 commented Jan 7, 2022

Is your proposal related to a problem?

Bucket replicate tool supports matchers to select data blocks with specified matchers. But now it just supports equal matchers and it is not very flexible to specify multiple values (tenants/clusters).
In case I need to replicates blocks from multiple clusters, then I have to use multiple thanos replicates.

It would be great to support all kind of matchers in the selector. If it is not that flexible from command line args, it would be good to also read matchers from files, too.

@GiedriusS
Copy link
Member

Perhaps the new matchers functionality (code) from Alertmanager could be used here?

@stale
Copy link

stale bot commented Apr 17, 2022

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Apr 17, 2022
@GiedriusS GiedriusS removed the stale label Apr 17, 2022
@stale
Copy link

stale bot commented Sep 21, 2022

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Sep 21, 2022
@kama910
Copy link
Contributor

kama910 commented Dec 22, 2022

Hello, may I work on this issue?

@yeya24
Copy link
Contributor Author

yeya24 commented Dec 22, 2022

@kama910 Sure please go ahead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants