Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow removing markers from object storage #5946

Closed
fpetkovski opened this issue Dec 7, 2022 · 1 comment · Fixed by #5977
Closed

Allow removing markers from object storage #5946

fpetkovski opened this issue Dec 7, 2022 · 1 comment · Fixed by #5977

Comments

@fpetkovski
Copy link
Contributor

fpetkovski commented Dec 7, 2022

Is your proposal related to a problem?

The thanos tools bucket mark command can only create new markers at the moment. It would be nice to allow it to also remove existing markers from object storage.

One use case is removing no-compaction markers which the Compactor adds when it estimates that the new block's index size will exceed the configured limit. An admin can increase the limit and remove this markers to retry compacting those blocks.

Describe alternatives you've considered

An alternative is to have a custom script, but this defeats the purpose of having a thanos tools package.

@maheshbaliga
Copy link
Contributor

Hi @fpetkovski, I will start working on this issue. I will need some help, since this will be my first issue here. Will get back with questions, if any. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants