"unhide" query.instant.default.max_source_resolution Flag

[rekup]

Hello everyone

We are using thanos ruler for some recording rules which do use offset to compare certain values to historic data. The offset hits a date range where we do not have any raw data, but only downsampled data. As a result, the query does not return any results. After some search we discovered the hidden flag --query.instant.default.max_source_resolution which was introduced in #1431. After configuring this option, our queries do work. I was wondering whether we could make this hidden flag a regular one by "unhiding" it

Describe the solution you'd like

Setting --query.instant.default.max_source_resolution to e.g. 1h resolves our issue but this flag is hidden by default and there is also no documentation for this flag.

Additional context

I am not sure why exactly this feature was implemented as a hidden flag. In my opinion, this feature could be interesting for others as well, and it might make sense to add some documentation for and make it a regular flag. Any opinions on this?
Everyone agrees, I would be happy to add documentation for this flag and "unhide" it.

Thanks,
Reto

[matej-g]

Hey @rekup,
Looks like this older comment might give some insight on why #1431 (review), I'd say if those reasons are still valid it makes sense to keep it hidden. Alternatively, we can document this use case and fix and still keep it hidden.