-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.*: /api/v1/label/<name>/values matchers not working #6959
Comments
Fairly sure that this is solved by #6879 if its about external labels |
Thanks @MichaHoffmann. Can we close this issue now or we need more verification? |
Closing because we believe it was fixed by #6879. Let us know if this persists. |
I've tested
But Labels request is broken:
v0.34.0-rc.0
Correct response in both cases should be: |
Thanks for the reproducer, let me take a look ! Edit: I cannot reproduce quickly with this test, the test passes 🤔
Edit2: Ok i think i found the issue! |
I think #7082 should fix this; at least the new test showed that if we have series matchers that dont match the external label we would return empty result which is buggy. |
@sepich I included the bugfix into 0.34.0-rc.1; can you test it out by any chance? |
Thank you for working on this! |
Thanos, Prometheus and Golang version used:
Thanos: quay.io/thanos/thanos:v0.32.5
Prometheus: quay.io/prometheus/prometheus:v2.47.2
Object Storage Provider:
Ceph S3
What happened:
Similar to #6878 I get unexpected amount of returned fields when accessing
/api/v1/label/<name>/values
.What you expected to happen:
I expect to only get the label value "fsn1" but instead I get all regions.
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know:
Query Range with the same query and time range. I reduced the json output to keep it simple. There are some more values returned and some more nodes that all have similar labels like in the example below. Only the instance and exported_instance changes.
The text was updated successfully, but these errors were encountered: