From af02b4d22ef415b02093ddb3b8520bb7b028fc55 Mon Sep 17 00:00:00 2001 From: Bartlomiej Plotka Date: Thu, 4 Jun 2020 18:05:44 +0100 Subject: [PATCH] Store: `irate` and `resets` use now counter downsampling aggregations. See related discussion: https://cloud-native.slack.com/archives/CL25937SP/p1590408991325100 Signed-off-by: Bartlomiej Plotka --- CHANGELOG.md | 1 + pkg/query/querier.go | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 784df2cf5a..f3ea403e50 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -28,6 +28,7 @@ We use *breaking* word for marking changes that are not backward compatible (rel - [#2525](https://github.com/thanos-io/thanos/pull/2525) Query: Fixed logging for dns resolution error in the `Query` component. - [#2484](https://github.com/thanos-io/thanos/pull/2484) Query/Ruler: Fixed issue #2483, when web.route-prefix is set, it is added twice in HTTP router prefix. - [#2416](https://github.com/thanos-io/thanos/pull/2416) Bucket: Fixed issue #2416 bug in `inspect --sort-by` doesn't work correctly in all cases +- [#2719](https://github.com/thanos-io/thanos/pull/2719) Store: `irate` and `resets` use now counter downsampling aggregations. ### Added diff --git a/pkg/query/querier.go b/pkg/query/querier.go index e4a9fded09..7fa8d44b6d 100644 --- a/pkg/query/querier.go +++ b/pkg/query/querier.go @@ -153,7 +153,7 @@ func aggrsFromFunc(f string) []storepb.Aggr { if strings.HasPrefix(f, "sum_") { return []storepb.Aggr{storepb.Aggr_SUM} } - if f == "increase" || f == "rate" { + if f == "increase" || f == "rate" || f == "irate" || f == "resets" { return []storepb.Aggr{storepb.Aggr_COUNTER} } // In the default case, we retrieve count and sum to compute an average.