Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💔 [Malformed]: Invalid DNS filter syntax rules in DNS filter #3062

Open
Metrokoto opened this issue Oct 6, 2024 · 1 comment
Open

💔 [Malformed]: Invalid DNS filter syntax rules in DNS filter #3062

Metrokoto opened this issue Oct 6, 2024 · 1 comment
Assignees
Labels
approved This issue was successfully reproduced and is in the process of being resolved dns AdVoid.DNS related issue malformed A malformed filter rule.

Comments

@Metrokoto
Copy link

Metrokoto commented Oct 6, 2024

Hello, fellow filterlist dev here.

Just letting you know that I noticed that your DNS filter contains rules with invalid syntax, such as rules containing $domain, $xmlhttprequest, as well as URLs such as example.com/ads, and rules that do not start with | or ||.

This may cause issues for some DNS blockers, could you please update the list to follow the AdGuard Home and PiHole syntax correctly?

The following sections have rules that should NOT be present in a DNS filterlist;

! {1} Domains - wildcard (global)
! {2} Domains - RegExp (global)
! {4} Subdomains (global)
! {6} Endpoints (site)

I use AdVoid.DNS with AdGuard Home, and I wish to avoid issues.

Here is a link to a filterlist with valid syntax to follow as a guide;

https://adguardteam.github.io/AdGuardSDNSFilter/Filters/filter.txt

@Metrokoto Metrokoto added malformed A malformed filter rule. pending-approval This issue is pending aproval labels Oct 6, 2024
@igorskyflyer
Copy link
Member

igorskyflyer commented Oct 6, 2024

Hi 👋🏻 @Metrokoto, thank you for raising awareness of this issue.

I am actually aware of the ongoing issue that is present in the DNS filter list. The issue is caused by the automation system I made and use, which is still in the development stage and works great but it lacks some functionality to output proper DNS rules (see why below).


I use:

I maintain a single domains list of rules which get compiled into appropriate output filter files. The missing link is that modifiers should be stripped for the DNS list to be completely valid, which I plan to add during a week or two, depending on the amount of free time I have.

About other non-domain rules, you are right, I'll evaluate which rules need to be removed from the list completely.

Cheers. 🙋🏻‍♂️

@igorskyflyer igorskyflyer added approved This issue was successfully reproduced and is in the process of being resolved dns AdVoid.DNS related issue and removed pending-approval This issue is pending aproval labels Oct 6, 2024
@igorskyflyer igorskyflyer pinned this issue Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue was successfully reproduced and is in the process of being resolved dns AdVoid.DNS related issue malformed A malformed filter rule.
Projects
None yet
Development

No branches or pull requests

2 participants