Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Value in wrong format is written to config on Windows with Russian localization #12

Closed
Gebcy opened this issue Mar 17, 2024 · 1 comment

Comments

@Gebcy
Copy link

Gebcy commented Mar 17, 2024

error.log
(Version 0.0.9)

Config with incorrect values on Russian localization:
chain_1_rife_factor_numerator=5,0
chain_1_rife_factor_denominator=1,0
chain_1_rife_scene_detect_threshold=0,100

Config with correct values on English localization:
chain_1_rife_factor_numerator=5.0
chain_1_rife_factor_denominator=1
chain_1_rife_scene_detect_threshold=0.10

I think this is due to regional differences in number formats. And this may happen not only with Russian localization, but also with all localizations that use a comma instead of a dot as a decimal separator.

@the-database
Copy link
Owner

Fixed in v1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants