Skip to content
This repository has been archived by the owner on Oct 15, 2021. It is now read-only.

Fixed warnings #8

Merged
merged 3 commits into from
Oct 16, 2018
Merged

Fixed warnings #8

merged 3 commits into from
Oct 16, 2018

Conversation

RomanPodymov
Copy link
Contributor

Good evening.
Thank you for this library.
In this pull request I just fixed all warnings and made a small refactoring.

Copy link
Contributor

@mkj-is mkj-is left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, we currently do not use the library and use another methods to get the user location, so this was a bit outdated.

if Bundle.main.object(forInfoDictionaryKey: "NSLocationAlwaysUsageDescription") != nil {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend turning off whitespace-only lines in Xcode. It makes diffs much more cleaner.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkj-is Or I can add SwiftLint for this repository.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RomanPodymov
Copy link
Contributor Author

Hello @mkj-is
This library has 8 forks, probably my changes will be useful for developers who created all these forks.

@mkj-is
Copy link
Contributor

mkj-is commented Oct 16, 2018

That's true. I am merging this PR. Thank you.

@mkj-is mkj-is merged commit 9f51d22 into futuredapp:master Oct 16, 2018
@RomanPodymov RomanPodymov deleted the refactoring branch October 16, 2018 19:51
@RomanPodymov RomanPodymov mentioned this pull request Jan 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants