fix the workspace pref not being applied on change #5498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elaihau
commented
Jun 17, 2019
lmcbout
reviewed
Jun 17, 2019
|
@akosyakov Are you fine with me merging this one for 0.8 release. This is a small PR, but in my opinion, it fixes a bug that users could easily hit. |
|
@svenefftinge Since Anton is not available this week, could you please take a quick look at this line and confirm if you are OK with the breaking change? Thank you ! Could you please also advise if you happen not to be available, so that I can ask someone else for his/her opinion? |
|
Is this the correct behavior?
I had the multi-workspace support as the defualt:
|
kittaakos
reviewed
Jun 26, 2019
packages/preferences/src/browser/workspace-preference-provider.ts
Outdated
Show resolved
Hide resolved
packages/preferences/src/browser/folders-preferences-provider.ts
Outdated
Show resolved
Hide resolved
added 2 commits
June 26, 2019 09:53
- fixed eclipse-theia#4811 Signed-off-by: elaihau <[email protected]>
- FolderPreferenceProvider should be associated with PreferenceScope.Workspace when it is used as a delegate of WorkspacePreferenceProvider in a one-folder workspace, otherwise changes made to the workspace preferences would not be applied to the IDE. - fixed eclipse-theia#5446 Signed-off-by: elaihau <[email protected]>
Thank you for the review @kittaakos ! The problem has been fixed and code updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix the workspace pref not being applied on change
Signed-off-by: elaihau [email protected]
added WorkspaceService.isMultiRootWorkspaceEnabled()
isMultiRootWorkspaceOpenedimplementation #4811Signed-off-by: elaihau [email protected]