Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestCleanup unit test #549

Closed
WeilerP opened this issue Jul 22, 2021 · 1 comment
Closed

TestCleanup unit test #549

WeilerP opened this issue Jul 22, 2021 · 1 comment
Assignees
@WeilerP
Labels
bug Something isn't working testing Related to unit tests

Comments

@WeilerP
Copy link
Member

WeilerP commented Jul 22, 2021

Description

For TestCleanup::test_cleanup_some, the columns of adata.var to keep is defined incorrectly here . Instead of

scvelo/tests/core/test_anndata.py

Line 144 in 639309d

obs_cols_to_keep += set(adata.var.columns).intersection(layers_to_keep)

it should be

var_cols_to_keep += set(adata.var.columns).intersection(layers_to_keep)
@WeilerP WeilerP added bug Something isn't working testing Related to unit tests labels Jul 22, 2021
@WeilerP WeilerP mentioned this issue Jul 22, 2021
Merged
@WeilerP
Copy link
Member Author

WeilerP commented Jul 22, 2021

Fixed by #550.

@WeilerP WeilerP closed this as completed Jul 22, 2021
@WeilerP WeilerP self-assigned this Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WeilerP WeilerP

Labels
bug Something isn't working testing Related to unit tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@WeilerP