Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Embed Extension #740

Closed
colinodell opened this issue Nov 6, 2021 · 0 comments · Fixed by #805
Closed

[RFC] Embed Extension #740

colinodell opened this issue Nov 6, 2021 · 0 comments · Fixed by #805
Assignees
Labels
enhancement New functionality or behavior implemented Change has been implemented
Milestone

Comments

@colinodell
Copy link
Member

colinodell commented Nov 6, 2021

Description

Provide an extension that generates embed codes for popular services like YouTube, GitHub Gists, etc.

The syntax will look like the image syntax, with the exception that the embed must be on its own line in the Markdown input.

In addition to handling popular services out-of-the-box, users should be able to easily define their own services.

Syntax

Any https:// on its own line would be considered embeddable content:

https://youtube.com/watch?v=zbA62fvGGyw

https://youtu.be/zbA62fvGGyw

https://gist.github.com/colinodell/ffdd892cedc43d07597cb73a9a72e668

But this would not, since the URL isn't on its own line:

Check out my favorite video: https://youtube.com/watch?v=zbA62fvGGyw
@colinodell colinodell added the enhancement New functionality or behavior label Nov 6, 2021
@colinodell colinodell added this to the v2.1 milestone Nov 6, 2021
@colinodell colinodell self-assigned this Nov 8, 2021
@colinodell colinodell modified the milestones: v2.1, v2.2 Dec 5, 2021
@colinodell colinodell modified the milestones: v2.2, v2.3 Jan 22, 2022
@colinodell colinodell linked a pull request Feb 6, 2022 that will close this issue
@close-label close-label bot added the implemented Change has been implemented label Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New functionality or behavior implemented Change has been implemented
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant