Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reconsider types-requests dependency #1988

Closed
jku opened this issue Apr 28, 2022 · 0 comments · Fixed by #1991
Closed

reconsider types-requests dependency #1988

jku opened this issue Apr 28, 2022 · 0 comments · Fixed by #1991
Labels
dependencies Pull requests that update a dependency file

Comments

@jku
Copy link
Member

jku commented Apr 28, 2022

We get a lot of dependency bumps from dependabot for types-requests: The dependency is in requirements-test.txt, I assume it brings in annotation stubs for requests so that mypy does not complain during lint.

These upgrades are annoying because typeshed (the project producing this package) does not make real releases. They don't even tag the releases in source: the packages just appear in pypi.org. So there is absolutely no way to know if the new version is something we want or what source version it represents -- meaning no way to review a dependency upgrade.

Our use of requests is pretty stable: no changes in months. I wonder if we should just tell mypy to ignore requests and stop depending on types-requests?

@jku jku added the dependencies Pull requests that update a dependency file label Apr 28, 2022
@jku jku closed this as completed in #1991 May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant