Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce release tags on merges into master (i.e. release bumps) #95

Closed
lukpueh opened this issue Mar 3, 2020 · 4 comments
Closed

Enforce release tags on merges into master (i.e. release bumps) #95

lukpueh opened this issue Mar 3, 2020 · 4 comments

Comments

@lukpueh
Copy link
Member

lukpueh commented Mar 3, 2020

#87 added versioning/release policies, plus a script that helps to enforce them. One of the policies is:

Merges with 'master' must be followed by a git tag for the new version number.

This policy is not enforced by the script, as the script is auto-executed on PRs, but this policy would need to be enforced post-merge.

It would be nice to either:

@joshuagl
Copy link
Member

joshuagl commented Mar 3, 2020

I really like the idea of auto-tag on merge to master, we could use something like this GitHub Action to enable that workflow https://github.com/marketplace/actions/automatic-releases

@trishankatdatadog
Copy link
Member

The Agent integrations workflows might be helpful to read, too...

Cc @ofek

@lukpueh
Copy link
Member Author

lukpueh commented Jun 3, 2020

otherwise insistently remind the maintainer to tag the release

We could have the release policy checker script on Travis post these lines as a comment using the GitHub API.

Might be a fun self-contained task for a student (cc @SantiagoTorres, @adityasaky)

@joshuagl
Copy link
Member

We did this in #148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants