Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freeze navigation while generating scrambles #624

Closed
campos20 opened this issue Oct 1, 2020 · 3 comments
Closed

Freeze navigation while generating scrambles #624

campos20 opened this issue Oct 1, 2020 · 3 comments

Comments

@campos20
Copy link
Member

campos20 commented Oct 1, 2020

Is your feature request related to a problem? Please describe.

Log in (you may use query parameter staging=true) and ask for scramble generation.

image

If you navigate away (e.g. for Manual Selection), you'll see just some bars.

image

Describe the solution you'd like

Freeze navigation (user can't click competitions or manual until the process is done).

Describe alternatives you've considered

As an alternative, Scramble Button could be a progress bar itself and if user navigates, progress is shown just on Scramble Button.

Additional context [OPTIONAL]

  • Open TNoodle
  • add ?staging=true to the URL.
  • Hit Log In
  • Pass some delegate's id (or you can use mine, 2015CAMP17)
  • Back to tnoodle, add choose a competition (if the user you selected has no upcoming competition, you can force one by adding a query competitionId, like http://localhost:3000/scramble?staging=true&competitionId=AustralianNationals2020)
  • Generate and navigate

If you choose freezing navigation, this won't be needed anymore.

// If user navigates during generation proccess, we still get the correct name

Also, it would be nice freezing copies, FMC buttons, MBLD cube and any other interactive field.

@shzcuber
Copy link
Contributor

shzcuber commented Nov 8, 2020

I'm on it

@shzcuber
Copy link
Contributor

shzcuber commented Nov 8, 2020

Hello,

I have the fmc buttons, mbld button, copies input, and sidebar buttons freeze when it's generating scrambles. In my forked repository, I pushed my changes on the branch feature/change-title, and then merged it with the master branch (I realized that I should've made a new branch instead of using feature/change-title only after I did my changes). Please let me know if I need to do anything more. Thanks.

@campos20
Copy link
Member Author

Fixed by #632

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants