Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

little changes in phangorn #71

Open
KlausVigo opened this issue Apr 29, 2017 · 2 comments
Open

little changes in phangorn #71

KlausVigo opened this issue Apr 29, 2017 · 2 comments

Comments

@KlausVigo
Copy link

Hi @MichelleKendall and @thibautjombart,
congrats that the paper is finally out (sorry I am late a few weeks). Just wanted you guys let know that I made some small changes to all the RF.dist(), wRF.dist() and KF.dist() which all handle rooted=TRUE, so they use clades instead of bipartitions. The behaviour for the rooted case is in many cases a bit weird. Also densiTree() got a lot of new arguments similar as in plot.phylo(), if you call the arguments it should behave the same, but it may have some interesting new features. All on github now.
Cheers,
Klaus

@thibautjombart
Copy link
Owner

Hi Klaus,
thanks for the heads up. Just to clarify: is it all backward compatible, or is there anything we should change?

@KlausVigo
Copy link
Author

It should be all backward compatible, as long as you use argument names. The argument rooted = FALSE in RF.dist() etc was mostly ignored, at least for the vectorized functions. I thought you may be you guys are interested in comparing clades.
densiTree got additional arguments. Only the use of col changed, if col was a vector it would use different colors for edges, now for trees. I doubt that it was used that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants