Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tedgeUrl field for firmware command created by c8y-mapper #2795

Conversation

rina23q
Copy link
Member

@rina23q rina23q commented Mar 25, 2024

Proposed changes

Cumulocity mapper adds tedgeUrl filed with the value: if the remoteUrl is c8y, using proxy url
otherwise, using the same url as remoteUrl

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

#2793

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Cumulocity mapper adds tedgeUrl filed with the value:
if the remoteUrl is c8y, using proxy url
otherwise, using the same url as remoteUrl

Signed-off-by: Rina Fujino <[email protected]>
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 96.07843% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 76.6%. Comparing base (281fe69) to head (d55ddd2).
Report is 19 commits behind head on main.

Additional details and impacted files
Files Coverage Δ
...s/c8y_mapper_ext/src/operations/firmware_update.rs 90.1% <96.0%> (+0.5%) ⬆️

... and 25 files with indirect coverage changes

Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
428 0 3 428 100 0s

Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@rina23q rina23q added this pull request to the merge queue Mar 25, 2024
Merged via the queue into thin-edge:main with commit dabb15e Mar 25, 2024
32 checks passed
@gligorisaev
Copy link
Contributor

How to test:

  1. Subscribe to the cmd topic, like:

te/device/main///cmd/firmware_update/+

  1. Create a firmware operation from c8y cloud, and see what is printed out by 1
  2. If you see tedgeUrl in the new firmware_update command payload, success

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants