Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent input naming convention #386

Closed
nitrocode opened this issue Sep 12, 2024 · 3 comments · Fixed by #391
Closed

Consistent input naming convention #386

nitrocode opened this issue Sep 12, 2024 · 3 comments · Fixed by #391

Comments

@nitrocode
Copy link

Most use snake case and other inputs use camel case. Could the next version have consistent inputs so if we wrap this action, we can also use consistent inputs?

e.g.

pr_number
filePath
GITHUB_TOKEN
@nitrocode nitrocode mentioned this issue Sep 12, 2024
Open
This was referenced Oct 9, 2024
Closed
Merged
@thollander
Copy link
Owner

Released in v3.0.0

@nitrocode
Copy link
Author

Thanks!

@nitrocode
Copy link
Author

The readme might need some updates too

https://github.com/thollander/actions-comment-pull-request?tab=readme-ov-file#comment-a-file-content

@nitrocode nitrocode mentioned this issue Oct 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@nitrocode @thollander