You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some changes were made to configurePath() in lib/Stylesheet.class.php that breaks the previous caching convention. The cached css files were previously stored under wp-content/uploads/wp-less/[theme]/ (where [theme] is equivalent to the theme folder name in use). However, since the aforementioned commit, the addition of basename() is causing the [theme] path portion to be stripped, since basename() returns nothing if the file doesn't already exist. Cached stylesheets are now being placed under wp-content/uploads/wp-less/, instead.
Anyone who was depending on that convention for relative paths from the cached stylesheet to other things, such as FontAwesome, will find that those components now quietly break.
The text was updated successfully, but these errors were encountered:
kkatpki
changed the title
Cache path broken
Cache path convention changed
Oct 23, 2014
I would also like to note that the addition of basename() renders the wp-less_stylesheet_compute_target_path filter useless, as it will strip any custom paths right out.
I would consider this a bug, as it no longer works as expected.
Thanks @kkatpki for raising the issue. Some details about the PR #61 have been requested in the aforementioned discussion. Let's see what emerges from it.
As detailed in this commit: b13596f
Some changes were made to
configurePath()
inlib/Stylesheet.class.php
that breaks the previous caching convention. The cached css files were previously stored underwp-content/uploads/wp-less/[theme]/
(where [theme] is equivalent to the theme folder name in use). However, since the aforementioned commit, the addition ofbasename()
is causing the [theme] path portion to be stripped, sincebasename()
returns nothing if the file doesn't already exist. Cached stylesheets are now being placed underwp-content/uploads/wp-less/
, instead.Anyone who was depending on that convention for relative paths from the cached stylesheet to other things, such as FontAwesome, will find that those components now quietly break.
The text was updated successfully, but these errors were encountered: