Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache path convention changed #71

Closed
kkatpki opened this issue Oct 23, 2014 · 2 comments
Closed

Cache path convention changed #71

kkatpki opened this issue Oct 23, 2014 · 2 comments
Labels

Comments

@kkatpki
Copy link

kkatpki commented Oct 23, 2014

As detailed in this commit: b13596f

Some changes were made to configurePath() in lib/Stylesheet.class.php that breaks the previous caching convention. The cached css files were previously stored under wp-content/uploads/wp-less/[theme]/ (where [theme] is equivalent to the theme folder name in use). However, since the aforementioned commit, the addition of basename() is causing the [theme] path portion to be stripped, since basename() returns nothing if the file doesn't already exist. Cached stylesheets are now being placed under wp-content/uploads/wp-less/, instead.

Anyone who was depending on that convention for relative paths from the cached stylesheet to other things, such as FontAwesome, will find that those components now quietly break.

@kkatpki kkatpki changed the title Cache path broken Cache path convention changed Oct 23, 2014
@kkatpki
Copy link
Author

kkatpki commented Oct 23, 2014

I would also like to note that the addition of basename() renders the wp-less_stylesheet_compute_target_path filter useless, as it will strip any custom paths right out.

I would consider this a bug, as it no longer works as expected.

@thom4parisot
Copy link
Owner

Thanks @kkatpki for raising the issue. Some details about the PR #61 have been requested in the aforementioned discussion. Let's see what emerges from it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants