Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(change) Check that all providers works without the field errorCode in the response #2035

Closed
7 tasks done
thomaspoignant opened this issue Jun 29, 2024 · 2 comments
Closed
7 tasks done

(change) Check that all providers works without the field errorCode in the response #2035

thomaspoignant opened this issue Jun 29, 2024 · 2 comments
Labels
change This is a change in the code that should not affect the users p2 Medium priority

Comments

@thomaspoignant
Copy link
Owner

thomaspoignant commented Jun 29, 2024 •
edited
Loading

Motivation

It should be OK to consider there is no error if the relay proxy is not returning any errorCode in the evaluation response API.

Requirements

Check that if we remove the field from the response that all providers are working as expected:

  • Java
  • Javascript
  • Python
  • Kotlin
  • .Net
  • GO
  • Swift
@thomaspoignant thomaspoignant added change This is a change in the code that should not affect the users needs-triage A priority should be added to the issue p2 Medium priority and removed needs-triage A priority should be added to the issue labels Jun 29, 2024
@thomaspoignant thomaspoignant changed the title (change) Check that all provider works without the field errorCode in the response (change) Check that all providers works without the field errorCode in the response Jun 29, 2024
@thomaspoignant
Copy link
Owner Author

I've opened a PR for the Java provider that was falling if errorCode was not provided:
open-feature/java-sdk-contrib#855

@thomaspoignant thomaspoignant mentioned this issue Jul 3, 2024
Merged
@thomaspoignant
Copy link
Owner Author

After doing so small changes we have checked that all providers are working without errorCode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
change This is a change in the code that should not affect the users p2 Medium priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thomaspoignant