Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log error when v0.x.x flag format is used #2399

Closed
thomaspoignant opened this issue Sep 20, 2024 · 2 comments · Fixed by #2422
Closed

Log error when v0.x.x flag format is used #2399

thomaspoignant opened this issue Sep 20, 2024 · 2 comments · Fixed by #2422
Assignees
@thomaspoignant
Labels
📍 Assigned change This is a change in the code that should not affect the users good first issue Good for newcomers p2 Medium priority stop v0 support Tag to group everything about the un-support of v0.x.x flag format

Comments

@thomaspoignant
Copy link
Owner

Warning

As mention in the issue #2398 we have decided to drop the support of the v0.x.x flag format.

Since we want to ease this transition for people still using the original format, we should start by introducing an ERROR log explaining that new versions of GO Feature Flag will no longer support this format.

The log should be:

ERROR: your flag <flag name> is using GO Feature Flag flag format v0.x.x. The support of this format will be removed soon, please consider migrating to the v1 format (see https://gofeatureflag.org/docs/tooling/migrate_v0_v1).
@thomaspoignant thomaspoignant added p2 Medium priority change This is a change in the code that should not affect the users stop v0 support Tag to group everything about the un-support of v0.x.x flag format good first issue Good for newcomers labels Sep 20, 2024
@thomaspoignant thomaspoignant mentioned this issue Sep 20, 2024
Open
@thomaspoignant
Copy link
Owner Author

/assign-me

@github-actions GitHub Actions
Copy link
Contributor

👋 Hey @thomaspoignant, thanks for your interest in this issue! 🎉

⚠ Note that this issue will become unassigned if it isn't closed within 10 days.

🔧 A maintainer can also add the 📌 Pinned label to prevent it from being unassigned automatically.

@thomaspoignant thomaspoignant mentioned this issue Sep 24, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thomaspoignant thomaspoignant

Labels
📍 Assigned change This is a change in the code that should not affect the users good first issue Good for newcomers p2 Medium priority stop v0 support Tag to group everything about the un-support of v0.x.x flag format
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add deprecation log for v0 flags thomaspoignant/go-feature-flag
1 participant
@thomaspoignant