Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove migration cli code #2402

Closed
thomaspoignant opened this issue Sep 20, 2024 · 2 comments · Fixed by #2457
Closed

Remove migration cli code #2402

thomaspoignant opened this issue Sep 20, 2024 · 2 comments · Fixed by #2457
Assignees
@Light2Dark
Labels
📍 Assigned change This is a change in the code that should not affect the users good first issue Good for newcomers p2 Medium priority stop v0 support Tag to group everything about the un-support of v0.x.x flag format

Comments

@thomaspoignant
Copy link
Owner

Warning

As mention in the issue #2398 we have decided to drop the support of the v0.x.x flag format.
Before creating a pull request for that, please check in the main issue if is the right moment to do it.

After we have stopped releasing the go-feature-flag-migration-cli (see #2400), we can now safely delete the code of the migration-cli.

To do this we should delete everything that is under the cmd/migrationcli folder.
@thomaspoignant thomaspoignant added good first issue Good for newcomers p2 Medium priority change This is a change in the code that should not affect the users stop v0 support Tag to group everything about the un-support of v0.x.x flag format labels Sep 20, 2024
@thomaspoignant thomaspoignant mentioned this issue Sep 20, 2024
Open
@Light2Dark
Copy link
Contributor

/assign-me
hii again, let me try this! I think it's relatively simple.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 6, 2024

👋 Hey @Light2Dark, thanks for your interest in this issue! 🎉

⚠ Note that this issue will become unassigned if it isn't closed within 10 days.

🔧 A maintainer can also add the 📌 Pinned label to prevent it from being unassigned automatically.

@thomaspoignant thomaspoignant mentioned this issue Oct 7, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Light2Dark Light2Dark

Labels
📍 Assigned change This is a change in the code that should not affect the users good first issue Good for newcomers p2 Medium priority stop v0 support Tag to group everything about the un-support of v0.x.x flag format
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove migrationcli code and relevant makefile code Light2Dark/go-feature-flag
2 participants
@thomaspoignant @Light2Dark