feat: Detect undefined variations #2563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for go-feature-flag-doc-preview canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2563 +/- ##
==========================================
+ Coverage 84.81% 85.39% +0.57%
==========================================
Files 100 100
Lines 4346 4436 +90
==========================================
+ Hits 3686 3788 +102
+ Misses 535 518 -17
- Partials 125 130 +5 ☔ View full report in Codecov by Sentry. |
kna
reviewed
Oct 24, 2024
internal/flag/rule.go
Outdated
| count += p | ||
| if _, ok := variations[k]; !ok { | ||
| return fmt.Errorf("invalid percentage: variation %s does not exists", k) |
There was a problem hiding this comment.
It might be better to change like this?
Suggested change
| return fmt.Errorf("invalid percentage: variation %s does not exists", k) | |
| return fmt.Errorf("invalid percentage: variation %s does not exist", k) |
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR we had a new check when validating a feature flag to check if we reference an undefined variation in one of the rule configuration.
The effect of this PR is double, it will allow the linter to detect those issues and it will discard this flag (and log an error) for misconfigured flags.
Closes issue(s)
Resolve #2562
Checklist