fix: Notifier should fire during runtime (if isInit is false)

[8ma10s]

Description

This is a bug fix for #2534

#2534 had an incorrect logic of NOT calling notifier when the status is not set to isInit (=upon polling).
It should:

• NOT call notifier only if isInit && DisableNotifierOnInit are BOTH true
• call the notifier in any other cases

Closes issue(s)

[netlify]

✅ Deploy Preview for go-feature-flag-doc-preview canceled.

Name	Link
🔨 Latest commit	d917efe
🔍 Latest deploy log	https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/671b42ea39b9b60008b4a97f

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.48%. Comparing base (209c7ad) to head (d917efe).
Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2569   +/-   ##
=======================================
  Coverage   85.48%   85.48%           
=======================================
  Files         100      100           
  Lines        4444     4444           
=======================================
  Hits         3799     3799           
  Misses        516      516           
  Partials      129      129           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[8ma10s]

@thomaspoignant sorry about that. I think the code currently doesn't call the notifiers if isInit is false, which probably affects all users.

As a hotfix, I've created a PR that does just the fix of the logic.

[thomaspoignant]

oh good catch, I missed this one.
Let me release the fix.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud