Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Gitlab Retriever) Add logic to allow gitlab retriever and non-public Git Repos #695

Closed
ruairi-wmf opened this issue Apr 17, 2023 · 0 comments · Fixed by #696
Closed

(Gitlab Retriever) Add logic to allow gitlab retriever and non-public Git Repos #695

ruairi-wmf opened this issue Apr 17, 2023 · 0 comments · Fixed by #696
Assignees
@ruairi-wmf
Labels
enhancement New feature or request p1 High priority

Comments

@ruairi-wmf
Copy link
Contributor

Requirements

We'd use this project for feature flags but need to use a private Gitlabd repo to host our flags.yaml rules.

I'll create a PR shortly with a suggested code addition for the retriever's folder.
@ruairi-wmf ruairi-wmf added enhancement New feature or request needs-triage A priority should be added to the issue labels Apr 17, 2023
@ruairi-wmf ruairi-wmf mentioned this issue Apr 17, 2023
Merged
7 tasks
@thomaspoignant thomaspoignant added p1 High priority and removed needs-triage A priority should be added to the issue labels Apr 17, 2023
@kodiakhq kodiakhq bot closed this as completed in #696 Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruairi-wmf ruairi-wmf

Labels
enhancement New feature or request p1 High priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Gitlab retriever ruairi-wmf/go-feature-flag
2 participants
@thomaspoignant @ruairi-wmf