Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twig replace now take an array parameter #19

Closed
yannbertrand opened this issue Jun 26, 2017 · 6 comments
Closed

Twig replace now take an array parameter #19

yannbertrand opened this issue Jun 26, 2017 · 6 comments

Comments

@yannbertrand
Copy link

The replace('%%', '%') is deprecated (since [email protected]) and is removed in [email protected].

Updating it by replace({ '%%': '%' }) fixes this 😄 .

https://stackoverflow.com/questions/33891023/deprecation-of-twig-filters-use-twig-simplefilter-instead

@thormeier
Copy link
Owner

thormeier commented Sep 7, 2017

Thank you for reporting, I'll fix this within the next few days :)

@thormeier
Copy link
Owner

Hello, unfortunately I wasn't able to find time to fix this issue yet and I'm sorry for that. I'm not as active on this project as I want to be, so maybe you could open a PR to fix this issue?

@iainhallam
Copy link

Is there any chance of this being merged into the main repo, please? Working with Symfony 4 this now presents an error using this bundle. A tagged release would also be welcome. Thanks!

@thormeier
Copy link
Owner

Just merged the PR. Thank you for your patience. I'm sorry for almost abandoning this project, I just haven't had the time to do anything since I started studying for my BSc.

Could this issue be resolved?

@thormeier
Copy link
Owner

@iainhallam Added a tagged release: https://github.com/thormeier/breadcrumb-bundle/tree/2.2.0

@yannbertrand
Copy link
Author

yannbertrand commented Apr 17, 2019

Hey! No need to excuse.

You are probably working on totally different stuff now (I have not been using Symfony since then).

You did your best at the time and it has been really useful. I'm really thankful for the work you did and lots of other persons probably are as well 😄

Thanks for closing this issue ❤️!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants