Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImportError from click causes pre-commit to fail #1734

Closed
mayaCostantini opened this issue Mar 29, 2022 · 2 comments · Fixed by #1735
Closed

ImportError from click causes pre-commit to fail #1734

mayaCostantini opened this issue Mar 29, 2022 · 2 comments · Fixed by #1735
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.

Comments

@mayaCostantini
Copy link
Contributor

Describe the bug
See #1733 (comment) and #1730 (comment)

To Reproduce
Open a PR in this repository and see the error for the black check.

Expected behavior
pre-commit check passes.

Additional context
Error log in Prow for #1733:

black....................................................................Failed
- hook id: black
- exit code: 1
Traceback (most recent call last):
  File "/opt/app-root/src/.cache/pre-commit/repohvodjssb/py_env-python3/bin/black", line 8, in <module>
    sys.exit(patched_main())
  File "/opt/app-root/src/.cache/pre-commit/repohvodjssb/py_env-python3/lib/python3.8/site-packages/black/__init__.py", line 1127, in patched_main
    patch_click()
  File "/opt/app-root/src/.cache/pre-commit/repohvodjssb/py_env-python3/lib/python3.8/site-packages/black/__init__.py", line 1113, in patch_click
    from click import _unicodefun  # type: ignore
ImportError: cannot import name '_unicodefun' from 'click' (/opt/app-root/src/.cache/pre-commit/repohvodjssb/py_env-python3/lib/python3.8/site-packages/click/__init__.py)
@mayaCostantini mayaCostantini added the kind/bug Categorizes issue or PR as related to a bug. label Mar 29, 2022
@mayaCostantini
Copy link
Contributor Author

/priority critical-urgent

@sesheta sesheta added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Mar 29, 2022
@mayaCostantini
Copy link
Contributor Author

mayaCostantini commented Mar 29, 2022

It looks like the issue is recent and was raised in the click repository: pallets/click#2232

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants