Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rmb-peer with the latest envelope data #977

Closed
AbdelrahmanElawady opened this issue Apr 7, 2024 · 1 comment
Closed

Update rmb-peer with the latest envelope data #977

AbdelrahmanElawady opened this issue Apr 7, 2024 · 1 comment
Assignees
Labels
rmb-sdk belongs to rmb type_feature New feature or request
Milestone

Comments

@AbdelrahmanElawady
Copy link
Collaborator

Description

rmb-relay v1.3.0 added a new optional relays field that is part of the Envelope to avoid chain updates delay: https://github.com/threefoldtech/rmb-rs/blob/v1.3.0/proto/types.proto#L75
This new field should have the current relays for the twin sending a request to a relay. It should be a list of relays in the format <hostname>, for example: relay.dev.grid.tf and relay.dev.02.grid.tf. neither protocol or port should be added (wss or :443).

Reference PR and Issue

@AbdelrahmanElawady AbdelrahmanElawady added type_feature New feature or request rmb-sdk belongs to rmb labels Apr 7, 2024
@rawdaGastan rawdaGastan added this to the 1.0.0 milestone Apr 14, 2024
@rawdaGastan rawdaGastan moved this to In Progress in 3.14.x Apr 14, 2024
@rawdaGastan rawdaGastan moved this from In Progress to Pending Review in 3.14.x Apr 14, 2024
@rawdaGastan rawdaGastan moved this from Pending Review to In Verification in 3.14.x May 7, 2024
@Omarabdul3ziz
Copy link
Contributor

verified:

  • the relays field is added to the challenge hash
  • tested an rmb call between:
    • zos node at version 3.10.5 that uses rmb-peer version 1.3.0
    • local client uses the latest rmb-sdk peer
      and call succeeded

@github-project-automation github-project-automation bot moved this from In Verification to Done in 3.14.x Jun 10, 2024
@rawdaGastan rawdaGastan modified the milestones: 1.0.0, v0.15.x Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rmb-sdk belongs to rmb type_feature New feature or request
Projects
Status: Done
Development

No branches or pull requests

3 participants