Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rmb-peer with the latest envelope data #2539

Closed
AbdelrahmanElawady opened this issue Apr 7, 2024 · 4 comments
Closed

Update rmb-peer with the latest envelope data #2539

AbdelrahmanElawady opened this issue Apr 7, 2024 · 4 comments
Assignees
Labels
rmb_direct_client type_feature New feature or request
Milestone

Comments

@AbdelrahmanElawady
Copy link
Contributor

Description

rmb-relay v1.3.0 added a new optional relays field that is part of the Envelope to avoid chain updates delay: https://github.com/threefoldtech/rmb-rs/blob/v1.3.0/proto/types.proto#L75
This new field should have the current relays for the twin sending a request to a relay. It should be a list of relays in the format <hostname>, for example: relay.dev.grid.tf and relay.dev.02.grid.tf. neither protocol or port should be added (wss or :443).

Reference PR and Issue

@xmonader xmonader added this to the 2.5.0 milestone Apr 16, 2024
@zaelgohary zaelgohary self-assigned this May 7, 2024
@zaelgohary
Copy link
Contributor

Investigation:

Still checking the required changes that need to be made.

@AbdelrahmanElawady
Copy link
Contributor Author

I should probably mention that sending relays as the part of the message will not work on networks other than devnet as peers aren't updated on other networks (mainly zos nodes).

@zaelgohary
Copy link
Contributor

WIP:

Updated the types.proto and generated the new types. Currently working on editing the challenge with the new relays.

@zaelgohary
Copy link
Contributor

Work completed:

Added relays to the envelope and set it whenever user sends the envelope. I also added it to the challenge the same way it's implemented in rmb-rs. However, whenever I try to run the example script from the direct client, I get failed signature error as shown below.

P.S. the old challenge works just fine.

image

@AbdelrahmanElawady Can you please check if I'm missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rmb_direct_client type_feature New feature or request
Projects
Status: Done
Development

No branches or pull requests

4 participants