Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use KeyboardEvent.code instead of KeyboardEvent.keyCode #957

Open
ankitprahladsoni opened this issue Sep 22, 2023 · 0 comments
Open

Use KeyboardEvent.code instead of KeyboardEvent.keyCode #957

ankitprahladsoni opened this issue Sep 22, 2023 · 0 comments

Comments

@ankitprahladsoni
Copy link

useCloseOnEscape relies on the deprecated KeyboardEvent.keyCode. It should be replaced with KeyboardEvent.code since it is breaking tests with user-event@14

Relevant discussion: #testing-library/user-event#969
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ankitprahladsoni