Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(transformers): remove workaround for ts < 4.0 in replace-resource transformer #1100

Merged
merged 1 commit into from
Oct 18, 2021
Merged

refactor(transformers): remove workaround for ts < 4.0 in replace-resource transformer #1100

merged 1 commit into from
Oct 18, 2021

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Oct 18, 2021

Summary

Since we stop supporting Angular 9, we can remove workaround for ts NodeFactory in replace-resource AST transformer

Test plan

Green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

Since we stop supporting Angular 9, we can remove workaround for ts `NodeFactory` in `replace-resource` AST transformer
@ahnpnl ahnpnl changed the title refactor(transformers): remove workaround for ts < 4.0 refactor(transformers): remove workaround for ts < 4.0 in replace-resource transformer Oct 18, 2021
@ahnpnl ahnpnl marked this pull request as ready for review October 18, 2021 20:15
@ahnpnl ahnpnl merged commit ce68298 into thymikee:main Oct 18, 2021
@ahnpnl ahnpnl deleted the replace-resource-refactor branch October 18, 2021 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant