Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(presets): improve transformIgnorePatterns value #1162

Merged
merged 1 commit into from
Nov 9, 2021
Merged

refactor(presets): improve transformIgnorePatterns value #1162

merged 1 commit into from
Nov 9, 2021

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Nov 9, 2021

Test plan

Green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@ahnpnl ahnpnl marked this pull request as ready for review November 9, 2021 19:23
@ahnpnl ahnpnl merged commit 99a4b1b into thymikee:main Nov 9, 2021
@ahnpnl ahnpnl deleted the improve-regex branch November 9, 2021 19:24
@@ -16,7 +16,7 @@ const basePreset = {
module.exports = {
defaults: {
...basePreset,
transformIgnorePatterns: ['node_modules/(?!@angular)'],
transformIgnorePatterns: ['node_modules/(?!.*\\.mjs$)'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice. So then each library no longer needs to be added here? That'll make it a lot simpler.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly, the new regex will capture all libraries which are built with Angular 13 CLI, as well as Angular packages themselves.

akunzai added a commit to akunzai/angular-boilerplate that referenced this pull request Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants