Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove reflect-metadata in setup-jest #1428

Merged
merged 1 commit into from
Apr 27, 2022
Merged

feat: remove reflect-metadata in setup-jest #1428

merged 1 commit into from
Apr 27, 2022

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Apr 27, 2022

Test plan

Green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Since now we are using Angular AST transformers, reflect-metadata is not needed anymore

Other information

N.A.

BREAKING CHANGE
Since now we are using Angular AST transformers, we don't need to have this minimal `reflect-metadata` anymore
@ahnpnl ahnpnl marked this pull request as ready for review April 27, 2022 09:57
@ahnpnl ahnpnl merged commit 5a36729 into thymikee:main Apr 27, 2022
@ahnpnl ahnpnl deleted the feat/remove-reflect-metadata branch April 27, 2022 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant