Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: refactor zone patch test method #361

Merged
merged 1 commit into from
Mar 15, 2020
Merged

fix: refactor zone patch test method #361

merged 1 commit into from
Mar 15, 2020

Conversation

JiaLiPassion
Copy link
Contributor

@JiaLiPassion JiaLiPassion commented Mar 13, 2020 •
edited
Loading

refactor the zone.js patch test method logic to handle all cases

  1. each with args
  2. each with args and done
  3. each with template string
  4. each with template string and done

Close #359.

@ahnpnl ahnpnl requested a review from wtho March 13, 2020 15:19
wtho
wtho reviewed Mar 15, 2020
View reviewed changes
Copy link
Collaborator

@wtho wtho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm glad the test cases cover more edge cases now.
Thanks once again for the contribution.

I am not sure how we can just remove the code added in the previous fix, can you quickly explain why it is not required anymore?

src/zone-patch/index.js Show resolved Hide resolved
src/zone-patch/index.js Show resolved Hide resolved
wtho
wtho approved these changes Mar 15, 2020
View reviewed changes
Copy link
Collaborator

@wtho wtho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks again!

@wtho wtho merged commit 4cc8708 into thymikee:master Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtho wtho wtho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

regression in zone patch in 8.1.1 with it.each as tagged template literal
2 participants
@JiaLiPassion @wtho