Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make AngularSnapshotSerializer compatible with Ivy #366

Merged
merged 1 commit into from
Mar 31, 2020
Merged

feat: make AngularSnapshotSerializer compatible with Ivy #366

merged 1 commit into from
Mar 31, 2020

Conversation

arturovt
Copy link
Contributor

@arturovt arturovt commented Mar 30, 2020

Summary

Closes: #351

Test Plan

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS ✅❌
Android ✅❌

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I mentioned this change in CHANGELOG.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)

Copy link
Collaborator

@ahnpnl ahnpnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@ahnpnl ahnpnl requested a review from wtho March 30, 2020 21:05
Copy link
Collaborator

@wtho wtho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks so much!

Just in case you are still open to enhance the serializer, have a look at #336

We could think about supporting a non-ivy version, although probably t's not worth the hassle.

  "angularCompilerOptions": {
    "enableIvy": false
  }

@wtho wtho merged commit c648786 into thymikee:master Mar 31, 2020
@arturovt arturovt deleted the issue-351 branch March 31, 2020 11:11
@Dixit199213bafna
Copy link

I have enabled ivy but I am using Angular version 10 and still i get the issue as PrettyFormatPluginError: Cannot read property 'element' of undefined

@wtho
Copy link
Collaborator

wtho commented Feb 5, 2021

Can you create a new issue? Preferably with a minimal reproduction, that would be awesome!

Seems like const { ɵivyEnabled } = require('@angular/core'); does currently not provide information about the usage of ivy.

Edit: nevermind, I saw the discsussion in the other thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants