feat(compiler): use replace-resources transformer from Angular
#708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE - `isolatedModules: true` will use `inline-files` and `strip-styles` transformers as default transformers. - `isolatedModules: false` will use `replace-resources` transformer from `@ngtools/webpack` (besides the existing `downlevel-ctor` transformer). This will make `jest-preset-angular` become closer to what Angular CLI does with Karma + Jasmine.
ahnpnl
added
the
💣 Breaking Changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
isolatedModules: false.inline-filesandstrip-stylesare only used forisolatedModules: true.With this change, we are 95% identical to the way
@angular/clidoes with Karma + Jasmine.Test plan
Added unit tests, e2e tests
Green CI
Does this PR introduce a breaking change?
isolatedModules: truewill useinline-filesandstrip-stylestransformers as default transformers.isolatedModules: falsewill usereplace-resourcestransformer from@ngtools/webpack(besides the existingdownlevel-ctortransformer). This will makejest-preset-angularbecome closer to what Angular CLI does with Karma + Jasmine.Other information
N.A.