Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sound browser sample numbering does not match superdirt #122

Open
cleary opened this issue Oct 24, 2020 · 2 comments
Open

Sound browser sample numbering does not match superdirt #122

cleary opened this issue Oct 24, 2020 · 2 comments

Comments

@cleary
Copy link

cleary commented Oct 24, 2020

In the new sound browser, if a sample has special characters in it's filename the reference index of the sample in the browser does not match the sample played by superdirt.

Simple example on pluck:1

Please note, this also affects the vscode extension, but is not resolved:
kindohm/vscode-tidalcycles#17

@ndr-brt
Copy link
Collaborator

ndr-brt commented Oct 26, 2020

I checked...
Seems like javascript order follows the "ASCII" sort, so, the files

'BS A#2 PI.wav'
'BS A1 PI.wav'

are already sorted, because the # is smaller than any number.

But, don't know in other OS, but in linux the same two files are ordered, at OS level as:

'BS A1 PI.wav'
'BS A#2 PI.wav'

SuperDirt doesn't apply a particular order, but it inherits it from the OS.

The possible solutions are:

  • force plugin to use OS sorting
  • force superdirt to use ASCII sorting

The first will be the best for me, but we should verify how to apply that sorting rules.

@yaxu
Copy link
Member

yaxu commented Oct 26, 2020

Yes it woudl be good to resolve this. There's an issue open here: musikinformatik/SuperDirt#131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants