Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UCP: auto-update reuse exist pull request #5

Open
you06 opened this issue Mar 3, 2020 · 2 comments
Open

UCP: auto-update reuse exist pull request #5

you06 opened this issue Mar 3, 2020 · 2 comments

Comments

@you06
Copy link
Contributor

you06 commented Mar 3, 2020

Description

When the auto-update being triggered frequently, there will be many opened PRs being generated, but only the latest one is required, the outdated unmerged PRs are spamming.

Score

  • 100

Mentor

@you06

Recommended Skills

  • Go

Learning Materials

@sunl888
Copy link
Contributor

sunl888 commented Mar 31, 2020

I'd like to finish it, but I don't have any ideas. Could you give me more information? 👍 thanks.

@you06
Copy link
Contributor Author

you06 commented Apr 1, 2020

The updated PR will be created here.
https://github.com/pingcap-incubator/cherry-bot/blob/53734a35c63e1f7b67a2654ceeffb478c122cd90/pkg/providers/auto-update/pr.go#L59

To reuse an exist PR, you need to find it and force push to the head branch. Unfortunately, there is not a way to find the exist PR directory, you may filter PRs by author, target branch and title to find out it (it's also ok to record in database if you would like to create a new table).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants