We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/info command should use full match, not partial match. eg: when has '/information' in comment, should not trigger add template function root cause: in the page, https://github.com/pingcap-incubator/cherry-bot/blob/master/pkg/providers/add-template/event.go should not use if len(temMatches) > 0 && strings.TrimSpace(temMatches[0]) == "/info" { should use if comment == '/info'
issueID := event.GetIssue().GetNumber() fmt.Println(issueID) //fmt.Println(comment) temMatches := templatePattern.FindStringSubmatch(comment) fmt.Println("temMatches:", temMatches) if len(temMatches) > 0 && strings.TrimSpace(temMatches[0]) == "/info" { e := c.addTemplate(issueID) if e != nil { err := errors.Wrap(e, "add template to comment fail") return err } } return nil }
The text was updated successfully, but these errors were encountered:
/label type/feature-requet
Sorry, something went wrong.
These labels are not found type/feature-requet.
type/feature-requet
/label type/feature-request
No branches or pull requests
Bug Report
/info command should use full match, not partial match.
eg:
when has '/information' in comment, should not trigger add template function
root cause:
in the page, https://github.com/pingcap-incubator/cherry-bot/blob/master/pkg/providers/add-template/event.go
should not use if len(temMatches) > 0 && strings.TrimSpace(temMatches[0]) == "/info" {
should use if comment == '/info'
The text was updated successfully, but these errors were encountered: