You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
control_last_fit() doesn't accept an allow_par argument, and sets it to TRUE by default when wrapping control_resamples. This causes issues after last_fit() for models that need native serialization methods to be passed between sessions.
I'd suggest we
add an allow_par argument to control_last_fit(), and
set its default to FALSE
I don't believe 2) would result in any slowdown for last_fit(), as there's only one fit occurring on the train fold of a train/test split. It would also allow users to last_fit() without needing to set allow_par for model engines that require native serialization.
This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.
control_last_fit()
doesn't accept anallow_par
argument, and sets it toTRUE
by default when wrappingcontrol_resamples
. This causes issues afterlast_fit()
for models that need native serialization methods to be passed between sessions.I'd suggest we
allow_par
argument tocontrol_last_fit()
, andFALSE
I don't believe 2) would result in any slowdown for
last_fit()
, as there's only one fit occurring on the train fold of a train/test split. It would also allow users tolast_fit()
without needing to setallow_par
for model engines that require native serialization.Reprex and more discussion in tidymodels/bonsai#52 (comment).
The text was updated successfully, but these errors were encountered: