Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accept allow_par in control_last_fit() #539

Closed
simonpcouch opened this issue Sep 14, 2022 · 1 comment · Fixed by #545
Closed

accept allow_par in control_last_fit() #539

simonpcouch opened this issue Sep 14, 2022 · 1 comment · Fixed by #545

Comments

@simonpcouch
Copy link
Contributor

simonpcouch commented Sep 14, 2022

control_last_fit() doesn't accept an allow_par argument, and sets it to TRUE by default when wrapping control_resamples. This causes issues after last_fit() for models that need native serialization methods to be passed between sessions.

I'd suggest we

  1. add an allow_par argument to control_last_fit(), and
  2. set its default to FALSE

I don't believe 2) would result in any slowdown for last_fit(), as there's only one fit occurring on the train fold of a train/test split. It would also allow users to last_fit() without needing to set allow_par for model engines that require native serialization.

Reprex and more discussion in tidymodels/bonsai#52 (comment).

@github-actions
Copy link

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant