-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confusing test failure for sf_transform_xy() "no arguments in initialization list" #5201
Comments
I'm relatively sure ggplot2 assumes that when {sf} is installed, the GDAL drivers work as intended. I agree that the error message isn't helpful, but it is thrown from an {sf} function so there is little control that ggplot2 has over the message other than wrapping every piece of {sf} related code in Other than maybe putting the |
{sf} owns the error message, but {ggplot2} owns the map data & I would guess could be responsible for knowing where it comes from & thus what drivers are needed to process it? @edzer WDYT? Is there anything reasonably straightforward {ggplot2} and/or {sf} could do to help with the error messaging here? |
@MichaelChirico I'm not sure; can you provide a reprex that triggers this, or point to where it happens? I've never seen the |
I can point to the line causing it: ggplot2/tests/testthat/test-coord_sf.R Line 290 in e0d54f6
But it will be hard to offer a reprex I'm afraid, sorry :\ |
I can only find the error message here, but that should not be callable (it's part of a standalone app, not the PROJ library we use). What does |
I'll have to return to this when I'm off leave in May |
|
That's a pretty old software stack; does the error persist with updated sys reqs? |
I'll report back when it's updated but that may take years :) |
I'm going to go ahead and close this issue as there isn't anything I can easily investigate. |
We are observing this test failure:
Probably this is related to missing certain GDAL drivers. But I hope you agree the error message is not very helpful. I'm not sure if this is something on the ggplot2 or the sf side; I know sf offers some things we could use to escape here e.g.
sf_extSoftVersion()
oris_driver_available()
:https://github.com/r-spatial/sf/blob/b798413d4cd681cd173f9bdc110f2a014555ee09/tests/testthat/test_read.R#L176
https://github.com/r-spatial/sf/blob/b798413d4cd681cd173f9bdc110f2a014555ee09/tests/testthat/test_read.R#L121
Happy to offer more details as needed but I'm not sure what would help.
FWIW, the issue also causes some examples to fail:
ggplot2/man/geom_map.Rd
Lines 125 to 162 in 519bc83
ggplot2/man/sf_transform_xy.Rd
Lines 27 to 43 in 519bc83
The text was updated successfully, but these errors were encountered: