Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'UTC' equality can be extended to other equivalent time zones #844

Closed
MichaelChirico opened this issue Dec 17, 2019 · 1 comment · Fixed by #845
Closed

'UTC' equality can be extended to other equivalent time zones #844

MichaelChirico opened this issue Dec 17, 2019 · 1 comment · Fixed by #845

Comments

@MichaelChirico
Copy link
Contributor

I just filed this at data.table: Rdatatable/data.table#4117

And this fix for base R: https://bugs.r-project.org/bugzilla/show_bug.cgi?id=17674

I notice also several usages of == 'UTC' or != 'UTC' in lubridate:

lubridate/R/parse.r:679:    if (tz == "UTC"){
lubridate/R/parse.r:703:    if (tz == "UTC") {
lubridate/R/parse.r:759:    if (tz != "UTC") {
lubridate/R/parse.r:802:      if (tz != "UTC"){
lubridate/R/stamp.r:110:          if (tz(x[[1]]) != "UTC")
lubridate/R/util.r:119:  if (tz == "UTC") utc
lubridate/R/POSIXt.r:35:  t0 <-if (tz == "UTC") origin else force_tz(origin, tz)

If you're amenable, I would file a PR to an equivalent is_utc internal utility & replace the above instances

@vspinu
Copy link
Member

vspinu commented Dec 17, 2019

Yes, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants