From 7b429cb8533eb6f41cd5534009e3da932b4b22c1 Mon Sep 17 00:00:00 2001
From: Max Schmeller <6088931+mojomex@users.noreply.github.com>
Date: Sat, 7 Sep 2024 00:32:49 +0900
Subject: [PATCH] chore(nebula_ros/launch): make sensor_models enum choices for
 the `sensor_model` launch argument (#189)

---
 nebula_ros/launch/continental_launch_all_hw.xml |  5 ++++-
 nebula_ros/launch/hesai_launch_all_hw.xml       | 11 ++++++++++-
 nebula_ros/launch/robosense_launch_all_hw.xml   |  5 ++++-
 nebula_ros/launch/velodyne_launch_all_hw.xml    |  6 +++++-
 4 files changed, 23 insertions(+), 4 deletions(-)

diff --git a/nebula_ros/launch/continental_launch_all_hw.xml b/nebula_ros/launch/continental_launch_all_hw.xml
index 0255e89f9..6fe9b1740 100644
--- a/nebula_ros/launch/continental_launch_all_hw.xml
+++ b/nebula_ros/launch/continental_launch_all_hw.xml
@@ -1,6 +1,9 @@
 <?xml version="1.0"?>
 <launch>
-    <arg name="sensor_model" default="ARS548"/>
+    <arg name="sensor_model">
+        <choice value="ARS548" />
+        <choice value="SRR520" />
+    </arg>
     <arg name="config_file" default="$(find-pkg-share nebula_ros)/config/radar/continental/$(var sensor_model).param.yaml"/>
 
     <arg name="odometry_topic" default="odometry_input"/>
diff --git a/nebula_ros/launch/hesai_launch_all_hw.xml b/nebula_ros/launch/hesai_launch_all_hw.xml
index 7e9686888..22e82fd69 100644
--- a/nebula_ros/launch/hesai_launch_all_hw.xml
+++ b/nebula_ros/launch/hesai_launch_all_hw.xml
@@ -1,6 +1,15 @@
 <?xml version="1.0"?>
 <launch>
-  <arg name="sensor_model" description="Pandar64|Pandar40P|PandarXT32|PandarXT32M|PandarAT128|PandarQT64|PandarQT128|Pandar128E4X"/>
+  <arg name="sensor_model">
+    <choice value="Pandar40P" />
+    <choice value="Pandar64" />
+    <choice value="Pandar128E4X" />
+    <choice value="PandarAT128" />
+    <choice value="PandarQT64" />
+    <choice value="PandarQT128" />
+    <choice value="PandarXT32" />
+    <choice value="PandarXT32M" />
+  </arg>
   <arg name="config_file" default="$(find-pkg-share nebula_ros)/config/lidar/hesai/$(var sensor_model).param.yaml"/>
 
   <node pkg="nebula_ros" exec="hesai_ros_wrapper_node" name="hesai_ros_wrapper_node" output="screen">
diff --git a/nebula_ros/launch/robosense_launch_all_hw.xml b/nebula_ros/launch/robosense_launch_all_hw.xml
index d544fb8b8..ea99dfee3 100644
--- a/nebula_ros/launch/robosense_launch_all_hw.xml
+++ b/nebula_ros/launch/robosense_launch_all_hw.xml
@@ -1,6 +1,9 @@
 <?xml version="1.0"?>
 <launch>
-  <arg name="sensor_model" description="Helios|Bpearl"/>
+  <arg name="sensor_model">
+    <choice value="Helios" />
+    <choice value="Bpearl" />
+  </arg>
   <arg name="config_file" default="$(find-pkg-share nebula_ros)/config/lidar/robosense/$(var sensor_model).param.yaml"/>
 
   <node pkg="nebula_ros" exec="robosense_ros_wrapper_node" name="robosense_ros_wrapper_node" output="screen">
diff --git a/nebula_ros/launch/velodyne_launch_all_hw.xml b/nebula_ros/launch/velodyne_launch_all_hw.xml
index d2f030b29..defd8c027 100644
--- a/nebula_ros/launch/velodyne_launch_all_hw.xml
+++ b/nebula_ros/launch/velodyne_launch_all_hw.xml
@@ -1,6 +1,10 @@
 <?xml version="1.0"?>
 <launch>
-  <arg name="sensor_model" description="VLP16|VLP32|VLS128"/>
+  <arg name="sensor_model">
+    <choice value="VLP16" />
+    <choice value="VLP32" />
+    <choice value="VLS128" />
+  </arg>
   <arg name="config_file" default="$(find-pkg-share nebula_ros)/config/lidar/velodyne/$(var sensor_model).param.yaml"/>
 
   <node pkg="nebula_ros" exec="velodyne_ros_wrapper_node" name="velodyne_ros_wrapper_node" output="screen">