Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AT128 HW interface crashes on GetLidarRange #129

Closed
mojomex opened this issue Mar 27, 2024 · 2 comments
Closed

AT128 HW interface crashes on GetLidarRange #129

mojomex opened this issue Mar 27, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@mojomex
Copy link
Collaborator

mojomex commented Mar 27, 2024

When launching Nebula when connected to AT128, the HW interface crashes with a segfault in GerLidarRange.
The AT128 TCP protocol does not support request code 0x23 (Get Azimuth FOV) and sends an error response, which Nebula does not check. Instead it assumes the payload is larger than the error response, resulting in a segfault.

@mojomex mojomex self-assigned this Mar 28, 2024
@mojomex mojomex added the bug Something isn't working label Mar 28, 2024
@mojomex
Copy link
Collaborator Author

mojomex commented Mar 28, 2024

As a first step, I made issues like these detectable by introducing error checking and handling in hesai_hw_interface:

@mojomex mojomex changed the title AT128 HW interface crashes on GerLidarRange AT128 HW interface crashes on GetLidarRange Mar 29, 2024
@mojomex
Copy link
Collaborator Author

mojomex commented Sep 26, 2024

Fixed by #131

@mojomex mojomex closed this as completed Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant