Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support KeySpace #545

Closed
4 tasks done
iosmanthus opened this issue Jul 14, 2022 · 2 comments
Closed
4 tasks done

Support KeySpace #545

iosmanthus opened this issue Jul 14, 2022 · 2 comments
Assignees

Comments

@iosmanthus
Copy link
Member

iosmanthus commented Jul 14, 2022

KeySpace is fundamental for transaction safety and multi-tenant features for TiKV. This is the tracking issue for the feature in client-go. For tracking issues of other components, check:

Currently, we only implemented the feature that writes data to the default keyspace in raw.Client leading to three major issues:

  • txn.Client is still in API V1. The transaction requests are not encoded: [WIP] Introduce Codec #557. @AmoebaProtozoa
  • Only default keyspace could be written. We should provide some API to write specified keyspace with their name or ID. @AmoebaProtozoa
  • If TiDB need writes different keyspaces, the coprocessor request should be encoded on the client side. Meanwhile, the TiKV coprocessor should decode the key before doing calculations. @iosmanthus

There are some bugs with the KeySpace feature in client-go, we track them here:

@pingyu
Copy link
Contributor

pingyu commented Aug 25, 2022

Please also request downstream tools (such as TiKV-BR & TiKV-CDC) to support KeySpace. Otherwise they will be abnormal on processing data with non-default KeySpace.

@v01dstar
Copy link
Contributor

v01dstar commented Jan 10, 2023

Will you update this https://github.com/pingcap/tidb/blob/master/store/driver/tikv_driver.go#L120 any soon? The client-go PR is blocking TiDB to have any further client-go changes, I think etcdAddrs, disableGC, _, err : = config.ParsePath can make it pass, but I am not sure whether this is the right way to go. @AmoebaProtozoa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants