Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The try times are not limited when stale read is used #902

Closed
cfzjywxk opened this issue Jul 24, 2023 · 1 comment
Closed

The try times are not limited when stale read is used #902

cfzjywxk opened this issue Jul 24, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@cfzjywxk
Copy link
Contributor

After https://github.com/tikv/client-go/pull/765/files#diff-0c36d07fbd1fc71c850ff57d323fe12bdf7f2c053ef71b7fec5bb44358f1070dR598, the retry time limit is removed when stale read is used and leaderOnly flag is set.

As mentioned in pingcap/tidb#45297, if region errors are encountered and the leader peer is not available, the retry may continue to happen and cause many unnecessary retries.
@cfzjywxk cfzjywxk added the bug Something isn't working label Jul 24, 2023
@cfzjywxk cfzjywxk mentioned this issue Jul 24, 2023
Merged
@cfzjywxk
Copy link
Contributor Author

cfzjywxk commented Feb 6, 2024

Closed by #903

@cfzjywxk cfzjywxk closed this as completed Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cfzjywxk